Quickfix popup stopped suggesting imports for JS #131840

2021-08-28T10:37:17Z

Does this issue occur when all extensions are disabled?: Yes/No (It requires ESLint extension to reproduce)

VS Code Version: 1.59.1
OS Version: Linux x64 5.4.0-45-generic

Version: 1.59.1
Commit: 3866c35
Date: 2021-08-19T11:54:37.513Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Linux x64 5.4.0-45-generic

Steps to Reproduce:

Context:

have a JS project with package.json with "type": "module" property.
Have ESLint extension installed, eslint dependency installed locally with npm install eslint
Have the following eslint configuration file .eslintrc.cjs:

module.exports = {
  'env': {
    'node': true,
    'es2021': true,
  },
  'extends': 'eslint:recommended',
  'parserOptions': {
    'ecmaVersion': 12,
    'sourceType': 'module'
  },
  'rules': {
  }
};

have two JS files first.js and second.js

// second.js
const myItem = 5;
export {myItem};

// first.js
const temp = myItem;

During typing of myItem in first.js the editor does suggest me to complete it and import, and on confirm it does complete and import myItem. (this part works even without ESLint extension and library)

But, if it is already completed, it does get underlined as a missing error and you can open a Quickfix popup. But in the Quickfix popup there is no suggestion to "Add the missing import".
Screenshot from 2021-08-28 12-53-06

The "Add the missing import" suggestion was present until sometime in the mid 2021. (But perhaps I disabled something in the settings also.)

The text was updated successfully, but these errors were encountered:

2021-08-30T15:20:20Z

If this only happens when eslint is enabled, please start by filing it against that extension

2021-08-30T20:47:13Z

vscode-eslint hasn't had production release since 2020, and this issue started to appear mid 2021.

Are typescript language features (built in into vscode) in charge of providing Quick Fix option Add missing import in JS files?

Because I do see that typescript language features provide Quick Fix options for <variable> is declared but its value is never read.ts(6133) error for example. And it also provides the autocomplete with automatic addition of missing import (which also changed behavior that after deleting the import it doesn't suggest it any more).

2021-08-30T22:37:48Z

Auto import come from VS Code itself but if this bug only happens when eslint is enabled, something with that extension is causing issues. Please put together a demonstration of the issue that doesn't require anything eslint and we'll take a look

2021-08-31T00:00:40Z

(Yes, I think it might be better to go with the issue through the vscode-eslint extension repo, even though the error might potentially be in the vscode API)

FYI:

The autoimport on autocompletion dropdown selection works fine! (as on the following two images)
Screenshot from 2021-08-31 01-31-55

What does not work is the following:

VSCode does provide a Quick Fix feature (API), the example of which can be seen on this image. The link Quick Fix... (Ctrl + .) at the bottom of the popup which opens a list of quick fix options.
the Quick Fix feature suddenly stopped providing "Add missing import" option (which I'm not sure if it is provided by the vscode-eslint Extension with the rule no-undef, or by the typescript language features). And nowonly the three quick fix options shown in the first post remained.
(NOTE: The "Fix this semi problem" quick fix option provided by vscode-eslint for semicolons is shown correctly for example)

2021-08-31T10:04:36Z

I made some progress. vscode-eslint is just forwarding the available fixes from the eslint library. And eslint library is not providing fixes for missing imports (and never had).

So either some eslint plugin was providing this or this was VSCode's built in feature.

Could it be that the typescript language features module provided the "Add missing import" and "Add all missing imports" quick fix options, and it stopped providing this two months ago for the JS? Because typescript language features does provide the autoimport on autocompletion.

croraf changed the title ~~Quickfix for javascript stopped suggesting imports~~ Quickfix popup stopped suggesting imports for JS Aug 28, 2021

croraf closed this as completed Aug 28, 2021

croraf reopened this Aug 28, 2021

croraf mentioned this issue Aug 28, 2021

Quick Fix popup stopped suggesting "Add missing import" for JS microsoft/vscode-eslint#1326

Closed

vscode-triage-bot assigned mjbvz Aug 28, 2021

mjbvz added the *caused-by-extension Issue identified to be caused by an extension label Aug 30, 2021

github-actions bot locked and limited conversation to collaborators Oct 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quickfix popup stopped suggesting imports for JS #131840

Quickfix popup stopped suggesting imports for JS #131840

croraf commented Aug 28, 2021 •

edited

mjbvz commented Aug 30, 2021

croraf commented Aug 30, 2021 •

edited

mjbvz commented Aug 30, 2021

croraf commented Aug 31, 2021 •

edited

croraf commented Aug 31, 2021 •

edited

Quickfix popup stopped suggesting imports for JS #131840

Quickfix popup stopped suggesting imports for JS #131840

Comments

croraf commented Aug 28, 2021 • edited

mjbvz commented Aug 30, 2021

croraf commented Aug 30, 2021 • edited

mjbvz commented Aug 30, 2021

croraf commented Aug 31, 2021 • edited

croraf commented Aug 31, 2021 • edited

croraf commented Aug 28, 2021 •

edited

croraf commented Aug 30, 2021 •

edited

croraf commented Aug 31, 2021 •

edited

croraf commented Aug 31, 2021 •

edited