-
Notifications
You must be signed in to change notification settings - Fork 1.8k
-
Star 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v26 regression] With autoHeight when resizing columns the height jumps and ends collapsed #4855
[v26 regression] With autoHeight when resizing columns the height jumps and ends collapsed #4855
Comments
croraf
commented
Jan 11, 2022
Removing:
in the new version seems to solve the issue and works properly. Anyways should be described in breaking changes if this is expected. |
makinggoodsoftware
commented
Jan 17, 2022
Hi, Your ticket has been flagged as in_zendesk, it means that we recognize this as an issue worth investigating so we have moved it to our official support channel for customers (zendesk) We will carry on there with the investigation and we will update you as soon as possible. Thanks |
kiril-matev
commented
Jan 18, 2022
Hi @croraf! Thank you for reporting this - much appreciated. The row auto-height rendering logic was changed in AG Grid v26.0 as part of: As part of this change row height changes are detected by the grid which refreshes the rows automatically without having to call gridApi.resetRowHeights() in the onColumnResized event handler as before. Actually keeping the calls This information was logged as part of MORE INFORMATION but not as a breaking change - thank you for noticing this omission. I've now corrected this and updated the to log this information specifically as a BREAKING CHANGE. I'm including this information below for full context: From v26.0 onward, keeping these calls to gridApi.resetRowHeights() causes flicker as rows render themselves twice instead of once. Please remove calls to gridApi.resetRowHeights() in onColumnResized event handler to avoid flicker in row re-rendering. Thanks for reporting this - we appreciate your time! |
croraf
commented
Jan 18, 2022
Great! |
I'm submitting a ... (check one with "x")
Requesting Community Support
Providing a Reproducible Scenario
https://plnkr.co/edit/n1XfecOoA655MXWc
(try resize couple of times)
Current behavior
When resizing, the height jumps. And sometimes the rows end up collapsed to the height of one line.
Expected behavior
The height should not jump when resizing, and should not collapse to the height of one line.
https://plnkr.co/edit/JiyS6XNTzMrWleA5 (v25.3.0)
Please tell us about your environment:
AG Grid version: X.X.X
community: 26.2.1
react: 26.2.0
Browser:
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36
NOTE: Seems to be introduced similarly as #4853
The text was updated successfully, but these errors were encountered: