Skip to content
/ ag-grid Public
  • Notifications You must be signed in to change notification settings
  • Fork 1.8k
  • Star 12k
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v26 regression] With autoHeight when resizing columns the height jumps and ends collapsed #4855

Closed
croraf opened this issue Jan 1, 2022 · 4 comments
Closed

[v26 regression] With autoHeight when resizing columns the height jumps and ends collapsed #4855

croraf opened this issue Jan 1, 2022 · 4 comments
Labels
in_zendesk

Comments

@croraf
Copy link

croraf commented Jan 1, 2022

I'm submitting a ... (check one with "x")

[x] bug report => see 'Providing a Reproducible Scenario'
[] feature request => do not use Github for feature requests, see 'Customers of AG Grid'
[] support request => see 'Requesting Community Support'

Requesting Community Support

Providing a Reproducible Scenario
https://plnkr.co/edit/n1XfecOoA655MXWc

(try resize couple of times)

Current behavior
When resizing, the height jumps. And sometimes the rows end up collapsed to the height of one line.
image

Expected behavior
The height should not jump when resizing, and should not collapse to the height of one line.
image
https://plnkr.co/edit/JiyS6XNTzMrWleA5 (v25.3.0)

Please tell us about your environment:

  • AG Grid version: X.X.X
    community: 26.2.1
    react: 26.2.0

  • Browser:

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36

NOTE: Seems to be introduced similarly as #4853

@croraf croraf changed the title (regression) With autoHeight when resizing columns the height jumps and ends collapsed [v26 regression] With autoHeight when resizing columns the height jumps and ends collapsed Jan 3, 2022
@croraf
Copy link
Author

croraf commented Jan 11, 2022

Removing:

const onColumnResized = (params) => {
    params.api.resetRowHeights();
  }

in the new version seems to solve the issue and works properly.
But, am not sure if it has some other consequences.

Anyways should be described in breaking changes if this is expected.

@makinggoodsoftware makinggoodsoftware added the in_zendesk label Jan 17, 2022
@makinggoodsoftware
Copy link
Contributor

makinggoodsoftware commented Jan 17, 2022

Hi,

Your ticket has been flagged as in_zendesk, it means that we recognize this as an issue worth investigating so we have moved it to our official support channel for customers (zendesk)

We will carry on there with the investigation and we will update you as soon as possible.

Thanks

@kiril-matev
Copy link

kiril-matev commented Jan 18, 2022

Hi @croraf!

Thank you for reporting this - much appreciated.

The row auto-height rendering logic was changed in AG Grid v26.0 as part of:
AG-5607 Enhance Row Auto Height Support

As part of this change row height changes are detected by the grid which refreshes the rows automatically without having to call gridApi.resetRowHeights() in the onColumnResized event handler as before. Actually keeping the calls
to gridApi.resetRowHeights() causes rows to render twice, producing the flicker you reported.

This information was logged as part of MORE INFORMATION but not as a breaking change - thank you for noticing this omission. I've now corrected this and updated the to log this information specifically as a BREAKING CHANGE.

I'm including this information below for full context:
The row auto-height behavior has been changed. When a column uses auto height (colDef.autoHeight=true), there is no need to call gridApi.resetRowHeights() in the onColumnResized event handler anymore to force the rows to update their row height after a column resize operation, as the grid will automatically resize the rows when it detects a height change.

From v26.0 onward, keeping these calls to gridApi.resetRowHeights() causes flicker as rows render themselves twice instead of once. Please remove calls to gridApi.resetRowHeights() in onColumnResized event handler to avoid flicker in row re-rendering.

Thanks for reporting this - we appreciate your time!

@croraf
Copy link
Author

croraf commented Jan 18, 2022

Great!

@croraf croraf closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in_zendesk
Projects
None yet
Development

No branches or pull requests

3 participants
@makinggoodsoftware @croraf @kiril-matev

Footer

© 2024 GitHub, Inc.

哆哆女性网饭店起名宽建筑劳务起公司名字婴幼儿起个好听的小名白景屹企业起名测名椿萱并茂是什么意思属猪孩子起名宜用的字男孩起名带修字的我懂事了易经起名称大全生日起名给新生儿起乳名女孩管道公司起名大全国学经典 起名电商公司起名参考姓高的名字怎么起平原烽火40校园智能广播千千起名软件手机街机游戏会议接待方案马到成功的意思寓意好诗词起名字用自己的名字起公司名字瓦房店新闻洋气的投资公司起名北京卫视节目单美女光屁屁聪慧激动的近义词淀粉肠小王子日销售额涨超10倍罗斯否认插足凯特王妃婚姻不负春光新的一天从800个哈欠开始有个姐真把千机伞做出来了国产伟哥去年销售近13亿充个话费竟沦为间接洗钱工具重庆警方辟谣“男子杀人焚尸”男子给前妻转账 现任妻子起诉要回春分繁花正当时呼北高速交通事故已致14人死亡杨洋拄拐现身医院月嫂回应掌掴婴儿是在赶虫子男孩疑遭霸凌 家长讨说法被踢出群因自嘲式简历走红的教授更新简介网友建议重庆地铁不准乘客携带菜筐清明节放假3天调休1天郑州一火锅店爆改成麻辣烫店19岁小伙救下5人后溺亡 多方发声两大学生合买彩票中奖一人不认账张家界的山上“长”满了韩国人?单亲妈妈陷入热恋 14岁儿子报警#春分立蛋大挑战#青海通报栏杆断裂小学生跌落住进ICU代拍被何赛飞拿着魔杖追着打315晚会后胖东来又人满为患了当地回应沈阳致3死车祸车主疑毒驾武汉大学樱花即将进入盛花期张立群任西安交通大学校长为江西彩礼“减负”的“试婚人”网友洛杉矶偶遇贾玲倪萍分享减重40斤方法男孩8年未见母亲被告知被遗忘小米汽车超级工厂正式揭幕周杰伦一审败诉网易特朗普谈“凯特王妃P图照”考生莫言也上北大硕士复试名单了妈妈回应孩子在校撞护栏坠楼恒大被罚41.75亿到底怎么缴男子持台球杆殴打2名女店员被抓校方回应护栏损坏小学生课间坠楼外国人感慨凌晨的中国很安全火箭最近9战8胜1负王树国3次鞠躬告别西交大师生房客欠租失踪 房东直发愁萧美琴窜访捷克 外交部回应山西省委原副书记商黎光被逮捕阿根廷将发行1万与2万面值的纸币英国王室又一合照被质疑P图男子被猫抓伤后确诊“猫抓病”

哆哆女性网 XML地图 TXT地图 虚拟主机 SEO 网站制作 网站优化